Skip to content

Comments

fix: unified font size to 16px#1860

Closed
Djfaucette wants to merge 4 commits intomainfrom
1859-jumplinks-type
Closed

fix: unified font size to 16px#1860
Djfaucette wants to merge 4 commits intomainfrom
1859-jumplinks-type

Conversation

@Djfaucette
Copy link
Contributor

@Djfaucette Djfaucette commented Feb 1, 2022

This is an extremely tiny change to Jump Links that resolves a font size mismatch.

Related issues

Preview

Link(s) to demo page(s) where this element can be viewed:

What has changed and why

  • The only files that have changed are a lockfile and sass file.

Testing instructions

Browser requirements

Your component should work in all of the following environments:

  • Latest 2 versions of Edge
  • Internet Explorer 11 (should be useable, not pixel perfect)
  • Latest 2 versions of Firefox (one on Mac OS, one of Windows OS)
  • Firefox 78 (or latest version for Red Hat Enterprise Linux distribution)
  • Latest 2 versions of Chrome (one on Mac OS, one of Windows OS)
  • Latest 2 versions of Safari
  • Android mobile device (such as the Galaxy S9)
  • Apple mobile device (such as the iPhone X)
  • Apple tablet device (such as the iPhone Pro)

Ready-for-merge Checklist

  • Expected files: all files in this pull request are related to one request or issue (no stragglers or scope-creep).
  • Tests have been updated to cover these changes.
  • Browser testing passed.
  • Changelog updated.
  • Documentation (README.md, WHY.md, etc.) updated or added.
  • Link to the demo recording:
  • Approved by designer.

Merging

Please squash when merging and ensure your commit message uses conventional commit formatting.

Be sure to share your updates with the patternfly-elements-contribute@redhat.com mailing list!

@changeset-bot
Copy link

changeset-bot bot commented Feb 1, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 083316c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Djfaucette
Copy link
Contributor Author

Djfaucette commented Feb 1, 2022

@coreyvickery

@github-actions github-actions bot added the styles An issue or PR pertaining only to CSS/Sass label Feb 1, 2022
@netlify
Copy link

netlify bot commented Feb 1, 2022 •
edited
Loading

✔️ Deploy Preview for patternfly-elements ready!

🔨 Explore the source changes: 083316c

🔍 Inspect the deploy log: https://app.netlify.com/sites/patternfly-elements/deploys/62017e719ab6ab0008e4195c

😎 Browse the preview: https://deploy-preview-1860--patternfly-elements.netlify.app

@github-actions github-actions bot added the AT passed Automated testing has passed label Feb 1, 2022
@bennypowers
Copy link
Member

bennypowers commented Feb 23, 2022

@Djfaucette We were pleased to merge pfe-2 earlier today. If this PR is still relevant, would you like help updating it?

@Djfaucette
Copy link
Contributor Author

Djfaucette commented Feb 24, 2022

@bennypowers I think that depends on the ETA of adoption for redhat.com

If it's less than 3 months I say we close this. In fact, I'll go ahead and close it. If the timeline is longer and we need to patch 1.x I'll let you reopen.

@Djfaucette Djfaucette closed this Feb 24, 2022
@bennypowers bennypowers deleted the 1859-jumplinks-type branch June 25, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

AT passed Automated testing has passed styles An issue or PR pertaining only to CSS/Sass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Djfaucette @bennypowers